Comments on: The Reassuring Review http://blog.qualityaspect.com/2006/08/17/the-reassuring-review/ Lidor Wyssocky's Blog on Optimizing Software Development Thu, 28 Aug 2008 11:52:32 +0000 http://wordpress.org/?v=1.5.2 Comment on The Reassuring Review by: Dave Nicolette http://blog.qualityaspect.com/2006/08/17/the-reassuring-review/#comment-1370 Mon, 21 Aug 2006 14:47:19 +0000 http://blog.qualityaspect.com/2006/08/17/the-reassuring-review/#comment-1370 Great insights, Lidor. As a frequent reader of Ed's blog, I gather that he has been introducing agile practices in his organization in an incremental way. Seems to me code reviews could be a great tool for advancing that effort. You suggest "reviewing more subtle issues." Let's offer a more specific recommendation. TDD is one of the most beneficial development practices people are using these days. The third step in the TDD cycle - refactoring - seems to create challenges (there's that word again) for many developers. Now that Ed's teams are past the point of making a lot of basic errors, what about using code reviews to mentor developers on exactlyhow to recognize when code needs refactoring, and then just what they need to do with the code to clean it up? I suggest Joshua Kerievsky's book, Refactoring to Patterns, for some practical guidance. Code reviews could be an effective tool to help developers apply those practices. It's not something you can pick up in five minutes of casual reading. The repeated sanity checks and reinforcement provided by code reviews seem like a great way to build those skills in an organization. As the development staff continues to improve its knowledge and effectiveness, continue raising the bar at code reviews to help them reach the next level. There shouldn't be a time when code reviews become obsolete, as long as you're targeting the right level of knowlege for the particular team. Great insights, Lidor. As a frequent reader of Ed’s blog, I gather that he has been introducing agile practices in his organization in an incremental way. Seems to me code reviews could be a great tool for advancing that effort. You suggest “reviewing more subtle issues.” Let’s offer a more specific recommendation.

TDD is one of the most beneficial development practices people are using these days. The third step in the TDD cycle - refactoring - seems to create challenges (there’s that word again) for many developers. Now that Ed’s teams are past the point of making a lot of basic errors, what about using code reviews to mentor developers on exactlyhow to recognize when code needs refactoring, and then just what they need to do with the code to clean it up?

I suggest Joshua Kerievsky’s book, Refactoring to Patterns, for some practical guidance. Code reviews could be an effective tool to help developers apply those practices. It’s not something you can pick up in five minutes of casual reading. The repeated sanity checks and reinforcement provided by code reviews seem like a great way to build those skills in an organization.

As the development staff continues to improve its knowledge and effectiveness, continue raising the bar at code reviews to help them reach the next level. There shouldn’t be a time when code reviews become obsolete, as long as you’re targeting the right level of knowlege for the particular team.

]]> Comment on The Reassuring Review by: Lidor Wyssocky http://blog.qualityaspect.com/2006/08/17/the-reassuring-review/#comment-1357 Sun, 20 Aug 2006 09:28:07 +0000 http://blog.qualityaspect.com/2006/08/17/the-reassuring-review/#comment-1357 Hi Ed, The question is are you utilizing your reviews to their full extent. You say that basic mistakes are rare. That's great. Now, how about reviewing more subtle issues? How about reviewing design decisions made by developers? How about trying to improve the quality of unit tests by reviewing them? I truly believe almost every developer can benefit from systematic reviews as long as their goal is to create improvement and increase professionalism. Lidor Hi Ed,

The question is are you utilizing your reviews to their full extent. You say that basic mistakes are rare. That’s great. Now, how about reviewing more subtle issues? How about reviewing design decisions made by developers? How about trying to improve the quality of unit tests by reviewing them?

I truly believe almost every developer can benefit from systematic reviews as long as their goal is to create improvement and increase professionalism.

Lidor

]]> Comment on The Reassuring Review by: Ed Gibbs http://blog.qualityaspect.com/2006/08/17/the-reassuring-review/#comment-1356 Sun, 20 Aug 2006 04:58:15 +0000 http://blog.qualityaspect.com/2006/08/17/the-reassuring-review/#comment-1356 After getting past the point of introducing code reviews, I do have a slight fear that they will seem less neccessary because developers are rarely making basic mistakes anymore. Every once in a while we don't find much in a particular review and of course the value question pops up even if no one verbalizes it. I've managed to avoid the first two points so far. Everyone on the team reviews everyone's code and I'm on some of the reviews and not others. As everyone becomes more accustomed to it I plan to drop off almost all the reviews. After getting past the point of introducing code reviews, I do have a slight fear that they will seem less neccessary because developers are rarely making basic mistakes anymore. Every once in a while we don’t find much in a particular review and of course the value question pops up even if no one verbalizes it.

I’ve managed to avoid the first two points so far. Everyone on the team reviews everyone’s code and I’m on some of the reviews and not others. As everyone becomes more accustomed to it I plan to drop off almost all the reviews.

]]>